Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typo in no-magic-numbers #12345

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@JosiahRooney
Copy link
Contributor

commented Sep 30, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added a missing "s" to "times" to correct the grammar.

Is there anything you'd like reviewers to focus on?

@jsf-clabot

This comment has been minimized.

Copy link

commented Sep 30, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Sep 30, 2019
@JosiahRooney JosiahRooney changed the title Fix typo Fix: Typo Sep 30, 2019
@JosiahRooney JosiahRooney changed the title Fix: Typo Chore: Typo Sep 30, 2019
@captchadex

This comment has been minimized.

Copy link

commented Sep 30, 2019

Nice

Copy link
Member

left a comment

LGTM, thanks!

Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo kaicataldo changed the title Chore: Typo Docs: fix typo in no-magic-numbers Sep 30, 2019
@kaicataldo

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@JosiahRooney Do you mind changing the commit message to match the PR title so that our CI check passes? This is important because we automate releases and the creation of changelogs using this format. Thank you for contributing!

@JosiahRooney JosiahRooney force-pushed the JosiahRooney:patch-1 branch from 27ff0ec to 9e47734 Oct 1, 2019
@JosiahRooney

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@kaicataldo I've amended the commit message to match. Thanks!

Copy link
Member

left a comment

Thanks for contributing!

@platinumazure platinumazure merged commit 0d3d7d9 into eslint:master Oct 1, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191001.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@JosiahRooney JosiahRooney deleted the JosiahRooney:patch-1 branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.