Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing word in sentence #12361

Merged
merged 1 commit into from Oct 3, 2019
Merged

Fix missing word in sentence #12361

merged 1 commit into from Oct 3, 2019

Conversation

@dboulet
Copy link
Contributor

dboulet commented Oct 2, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Very minor change to the documentation.

Is there anything you'd like reviewers to focus on?
No.

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Oct 2, 2019
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Oct 2, 2019

Thanks for contributing to ESLint! Do you mind updating the commit message to the format we request in the commit-message check? Doing so helps us automate our release and change log creation process.

@dboulet dboulet force-pushed the dboulet:patch-1 branch from ef3ae1f to ede1e02 Oct 3, 2019
@dboulet

This comment has been minimized.

Copy link
Contributor Author

dboulet commented Oct 3, 2019

Thanks, @kaicataldo. I’ve amended my commit message and all checks are now passing.

Copy link
Member

platinumazure left a comment

Looks good, thanks for contributing!

@platinumazure platinumazure merged commit c47fa0d into eslint:master Oct 3, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191003.7 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@dboulet dboulet deleted the dboulet:patch-1 branch Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.