Update: improve report location for no-space-in-parens #12364
Merged
Conversation
|
This mostly LGTM, thanks! Could we add some tests that have multiple spaces just so we're sure what the behavior should be then? |
|
LGTM, thanks! |
|
LGTM, thanks! Tried in VS Code, highlighting looks good: It might look a little strange that the locations in the messages are same for both left and right paren when there is nothing inside. Also, the message 'There should be no space before this paren' shows a location that is far from that paren. But I think it's okay. |
|
I'll champion. This is now accepted. |
|
Looks good to me, thanks for contributing! |
18a0b0e
into
eslint:master
16 checks passed
16 checks passed
continuous-integration (Test on Node.js 12 (Windows))
Test on Node.js 12 (Windows) succeeded
Details
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

What is the purpose of this pull request? (put an "X" next to item)
[x] Changes an existing rule
What changes did you make? (Give an overview)
Change the report location of no-space-in-parens. When option
never, location is changed to that of the disallowed spaces. When option 'always', missing end location is added. This change fixes part of #12334, where missing end location causes VS code to render highlighting tildes in unexpected locations.Is there anything you'd like reviewers to focus on?
No