Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix minor formatting/grammar errors #12371

Merged
merged 7 commits into from Oct 4, 2019
Merged

Docs: Fix minor formatting/grammar errors #12371

merged 7 commits into from Oct 4, 2019

Conversation

@cherryblossom000
Copy link
Contributor

@cherryblossom000 cherryblossom000 commented Oct 4, 2019

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

  • Fixed link to code conventions from the pull requests doc
  • "[[Call]]" => "[[Call]]" in no-obj-calls doc
  • Object literal spacing in example config in space-infix-ops
  • "may have optional description" => "may have an optional description" in symbol-description

Is there anything you'd like reviewers to focus on?

No.

All other example configs in the docs spaced curly braces in object literals, so this commit updates this for consistency.
@eslint-deprecated eslint-deprecated bot added the triage label Oct 4, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Thanks for contributing!

docs/developer-guide/contributing/pull-requests.md Outdated Show resolved Hide resolved
@kaicataldo kaicataldo added documentation and removed triage labels Oct 4, 2019
This reverts commit ab5dba7.
Sorry for all the commits.
Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Looks good, thanks for contributing!

@kaicataldo kaicataldo merged commit 3642342 into eslint:master Oct 4, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191004.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@cherryblossom000 cherryblossom000 deleted the cherryblossom000:docs-errors branch Oct 4, 2019
captbaritone added a commit to captbaritone/eslint that referenced this pull request Oct 5, 2019
* Docs: Fix link to code conventions

* Docs: Fix formattting

* Docs: Fix formatting of example config

All other example configs in the docs spaced curly braces in object literals, so this commit updates this for consistency.

* Docs: Fixed grammar

* Docs: Revert link to code conventions

This reverts commit ab5dba7.

* Docs: Revert link to code conventions

* Docs: Revert link to code conventions

Sorry for all the commits.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants