Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add no-error-on-unmatched-pattern flag (fixes #10587) #12377

Merged
merged 2 commits into from Dec 20, 2019

Conversation

@ncraley
Copy link
Contributor

@ncraley ncraley commented Oct 4, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #10587

What changes did you make? (Give an overview)

Added a flag to prevent errors when an unquoted glob pattern or --ext is not matched.

Is there anything you'd like reviewers to focus on?

I still need to confirm behavior when combined with other CLI options (and possibly add tests for that), but wanted to go ahead and put this out for initial feedback.

Add flag to prevent errors when a pattern or --ext is not matched
@arthurdenner
Copy link
Contributor

@arthurdenner arthurdenner commented Nov 21, 2019

@ncraley, can you solve the conflicts here, please? I'm not a maintainer, but I think this may help get this merged soon. cc @kaicataldo

Copy link
Member

@kaicataldo kaicataldo left a comment

Sorry this fell through the cracks. Thanks for the ping!

Pending resolving the merge conflicts, this LGTM, though I’d love another pair of eyes on this.

@ncraley
Copy link
Contributor Author

@ncraley ncraley commented Nov 22, 2019

@arthurdenner thanks, I'll knock out those conflicts tomorrow.

Copy link
Member

@platinumazure platinumazure left a comment

Looks good, thanks for contributing!

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

LGTM, thanks!

@btmills btmills merged commit 1713d07 into eslint:master Dec 20, 2019
18 checks passed
18 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 13.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 8.x)
Details
@github-actions
Test (ubuntu-latest, 8.10.0)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message PR title follows commit message guidelines
Details
@azure-pipelines
continuous-integration Build #20191122.13 succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants