Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add enforceForIndexOf option to use-isnan (fixes #12207) #12379

Merged
merged 2 commits into from Oct 25, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Oct 5, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12207

Examples of incorrect code for this rule with "enforceForIndexOf" option set to true:

/*eslint use-isnan: ["error", {"enforceForIndexOf": true}]*/

var hasNaN = myArray.indexOf(NaN) >= 0;

var firstIndex = myArray.indexOf(NaN);

var lastIndex = myArray.lastIndexOf(NaN);

What changes did you make? (Give an overview)

New option enforceForIndexOf in the use-isnan rule.

Is there anything you'd like reviewers to focus on?

It seemed too complex to have an advice in the message since it depends on whether the user wants to find index or just check for existence, and also what environments are available. There are examples in the docs for different environments.

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 20, 2019

This looks good to me, but I'll leave it open another day or two in case other team members want to review.

Sorry for letting this slip through the cracks.

@platinumazure platinumazure merged commit c6a9a3b into master Oct 25, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191008.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure platinumazure deleted the issue12207 branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.