Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
New: Add suggestions API #12384
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
As a new contributor implementing a core addition, everything should probably be scrutinized closely. In particular, I would like some advice on tests, including additional tests that should be written.
platinumazure left a comment
Just to throw in an early wrinkle: Should we consider supporting something similar to
I probably should have thought of this in the RFC stage, sorry.
Just a heads up for anyone that is interested in this work. I am currently traveling internationally and it looks like I won't have time to work on this while I'm gone. If anyone is motivated to move this forward, go for it. Otherwise, I will try to get back to it when I'm available again in about 3 weeks.
Just getting around to working on this again. I pushed up some work-in-progress commits to get some feedback on the approach.
@platinumazure in response to your comment about "supporting something similar to