New: pass cwd from cli engine #12389
Conversation
|
Thanks for working on this! I think the new Linter config object should be optional so that it’s not a breaking change (and we don’t have to add that empty object everywhere). Do you mind updating the documentation as well? |
|
Thank you for your contribution! |
|
Thank you for the quick update! Almost LGTM, but I have a few suggestions. |
|
Some suggestions around documentation. Otherwise, this LGTM. Thanks for working on this! |
|
Ah, also forget to mention: can you change the commit message from Edited: @mysticatea Whoops, yes! Thank you for catching that. |
|
@kaicataldo I guess you meant |
ef4119c
to
aea3c0d
1279c98
to
be20d43
|
LGTM, thanks! |
|
LGTM, thank you! |
874fe16
into
eslint:master
|
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Pass the cwd from the cli engine
#11218
RFC link: eslint/rfcs#35
Is there anything you'd like reviewers to focus on?
Linter.js