Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: remove default overrides in keyword-spacing (fixes #12369) #12411

Merged
merged 2 commits into from Oct 18, 2019

Conversation

@yeonjuan
Copy link
Member

yeonjuan commented Oct 12, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Remove default property in overrides scheme
I found that the overrides scheme's default value override the undeclared overrides option's value

Is there anything you'd like reviewers to focus on?
fix #12369,

Copy link
Member

platinumazure left a comment

This looks good to me, but I'd like to get another set of eyes on this before merging. Thanks for contributing!

@platinumazure platinumazure added accepted bug rule and removed triage labels Oct 17, 2019
Copy link
Member

mdjermanovic left a comment

Thanks for the PR! It would be good to have the name of this rule in the PR title.

tests/lib/rules/keyword-spacing.js Show resolved Hide resolved
@yeonjuan yeonjuan changed the title Update: remove default property in override scheme (fixes #12369) Update: remove default value in keyword-spacing override schemes (fixes #12369) Oct 18, 2019
@yeonjuan yeonjuan changed the title Update: remove default value in keyword-spacing override schemes (fixes #12369) Update: remove default override in keyword-spacing (fixes #12369) Oct 18, 2019
@yeonjuan yeonjuan changed the title Update: remove default override in keyword-spacing (fixes #12369) Update: remove default overrides in keyword-spacing (fixes #12369) Oct 18, 2019
@yeonjuan yeonjuan requested a review from mdjermanovic Oct 18, 2019
Copy link
Member

mdjermanovic left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit 84f71de into eslint:master Oct 18, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191018.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.