Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: enforceForOrderingRelations no-unsafe-negation (fixes #12163) #12414

Merged
merged 8 commits into from Oct 21, 2019

Conversation

@samrae7
Copy link
Contributor

samrae7 commented Oct 13, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Add enforceForOrderingRelations option to no-unsafe-negation rule. See:
#12163

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 13, 2019
@samrae7 samrae7 force-pushed the samrae7:issue12163 branch from a6d5e30 to d027b98 Oct 13, 2019
@samrae7 samrae7 force-pushed the samrae7:issue12163 branch from d027b98 to 85b5b1c Oct 13, 2019
Copy link
Member

mdjermanovic left a comment

Thanks for the PR! I left some notes for tests and the documentation.

docs/rules/no-unsafe-negation.md Outdated Show resolved Hide resolved
docs/rules/no-unsafe-negation.md Outdated Show resolved Hide resolved
tests/lib/rules/no-unsafe-negation.js Outdated Show resolved Hide resolved
tests/lib/rules/no-unsafe-negation.js Show resolved Hide resolved
tests/lib/rules/no-unsafe-negation.js Show resolved Hide resolved
samrae7 added 3 commits Oct 18, 2019
- typos
- clarity of docs
- extra test cases
Copy link
Member

platinumazure left a comment

Looks good to me, once @mdjermanovic's concerns are addressed.

Copy link
Member

mdjermanovic left a comment

Thanks! Just one small detail in the docs.

Could you please also change the PR title to end with (fixes #12163) ? Here are some examples.

To avoid confusion, there is no need to change commit messages. Since this PR has multiple commits, the convention from the link above applies to the PR title.


### enforceForOrderingRelations

With this option set to true, the rule is additionally enforced for:

This comment has been minimized.

Copy link
@mdjermanovic

mdjermanovic Oct 18, 2019

Member

It would be good to put backticks around true

@samrae7 samrae7 changed the title Update: add enforceForOrderingRelations option to no-unsafe-negation … Update: add option to no-unsafe-negation (fixes #12163) Oct 19, 2019
@samrae7

This comment has been minimized.

Copy link
Contributor Author

samrae7 commented Oct 19, 2019

Thanks @mdjermanovic. I've addressed the change and fixed the PR title.

Copy link
Member

mdjermanovic left a comment

LGTM, thanks!

@platinumazure would Update: enforceForOrderingRelations no-unsafe-negation (fixes #12163) be a more descriptive title?

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 20, 2019

@mdjermanovic I'm not really worried in this case, because I'm pretty sure we would add more information about this change in the Highlights section of the release notes. So we can clarify the option name at that point. If you feel strongly, though, feel free to leave a Request Changes review (as I have no objection to the change either).

Copy link
Member

mdjermanovic left a comment

@samrae7 Could we please insert the option's name in the PR title, I believe it's better for the commit history.

It could be something like Update: enforceForOrderingRelations no-unsafe-negation (fixes #12163)

It isn't a correct sentence, but the keywords are included :-)

@samrae7 samrae7 changed the title Update: add option to no-unsafe-negation (fixes #12163) Update: add option enforceForOrderingRelations to no-unsafe-negation (fixes #12163) Oct 21, 2019
@samrae7

This comment has been minimized.

Copy link
Contributor Author

samrae7 commented Oct 21, 2019

@mdjermanovic sure, done.

@samrae7 samrae7 changed the title Update: add option enforceForOrderingRelations to no-unsafe-negation (fixes #12163) Update: enforceForOrderingRelations no-unsafe-negation (fixes #12163) Oct 21, 2019
Copy link
Member

mdjermanovic left a comment

Thanks!

@platinumazure platinumazure merged commit 7c8bbe0 into eslint:master Oct 21, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191019.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 21, 2019

Merged! Thanks @samrae7 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.