Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: deprecate personal config (fixes #11914, refs eslint/rfcs#32) #12426

Merged
merged 8 commits into from Nov 15, 2019

Conversation

@mysticatea
Copy link
Member

mysticatea commented Oct 14, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[X] Other, please explain: deprecate a core feature

What changes did you make? (Give an overview)

This PR soft-deprecates the personal config file. This decision happened on RFC32 after RFC28's discussion. I removed the scattered descriptions about the personal config file then added those as the last section. Therefore, people can know what is deprecated clearly.

This is documentation-only change, but the label of this PR is Update: because deprecation should be semver-minor.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

Copy link
Member

platinumazure left a comment

Just requesting two small wording changes, otherwise this looks good to me. Thanks!

docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
mysticatea and others added 2 commits Oct 29, 2019
Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>
Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>
@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Oct 29, 2019

Thank you for review. I have applied your suggestions.

Copy link
Member

kaicataldo left a comment

Thanks for working on this! Left a few suggestions.

docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
mysticatea and others added 5 commits Nov 2, 2019
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Nov 14, 2019

I have updated this PR to follow the review.

Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Nov 15, 2019

@platinumazure Mind giving this one more look to confirm your concerns have been addressed?

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Nov 15, 2019

I apologize, I had forgotten about this one. Thanks @mysticatea and @kaicataldo for your patience!

@kaicataldo kaicataldo merged commit b8030fc into master Nov 15, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191114.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the deprecate-personal-config branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.