Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: report full dot location in dot-location #12452

Merged
merged 1 commit into from Oct 20, 2019
Merged

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 17, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

Fixes dot-location to report the full location of the dot token instead of just its start. This can improve highlighting behavior in editors.

For example, Online Demo at the moment doesn't highlight anything.

What changes did you make? (Give an overview)

dot.loc.start -> dot.loc

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage label Oct 17, 2019
@mdjermanovic
Copy link
Member Author

@mdjermanovic mdjermanovic commented Oct 17, 2019

I think that this PR, #12324 and #12328 can be accepted as bug fixes.

@platinumazure platinumazure added accepted bug rule and removed triage labels Oct 17, 2019
@platinumazure platinumazure merged commit e657d4c into master Oct 20, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191017.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure platinumazure deleted the dotlocation-location branch Oct 20, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants