Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update: Enable function string option in comma-dangle (fixes #12058) #12462
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
platinumazure left a comment
Are there any tests which show that functions are ignored by default when ecmaVersion < 8?
I didn't see any new tests along those lines and a quick skim of the existing
mdjermanovic left a comment
Thanks for the correct change and comprehensive tests! I left just one minor note for an additional test.
I think it's correct to treat this as a bug fix with more warnings for a semver-minor, because this behavior
Also, it's possible to reconfigure the rule if the new warnings are not desired (might be good to put a note in the release blog post?).
Apologies, I meant an additional test in
The test case you added is anyway useful and should stay.
If you can it would be nice to add one more test with