Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused parameter in dot-location #12464

Merged
merged 1 commit into from Oct 24, 2019
Merged

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 19, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

The obj param in dot-location check function became unused after some changes. Both obj and prop are redundant since the third param is their MemberExpression node.

What changes did you make? (Give an overview)

Removed the unused obj param and the unnecessary prop param in dot-location.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage label Oct 19, 2019
@mdjermanovic
Copy link
Member Author

@mdjermanovic mdjermanovic commented Oct 19, 2019

It's again failing on macOS - Install Packages, but it's possible to see the log now.

@mdjermanovic mdjermanovic added chore and removed triage labels Oct 19, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Looks good to me, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit e5382d6 into master Oct 24, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191019.7 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the dotlocation-unusedparam branch Oct 24, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants