Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-obj-calls false positive (fixes #12437) #12467

Merged
merged 1 commit into from Oct 24, 2019
Merged

Fix: no-obj-calls false positive (fixes #12437) #12467

merged 1 commit into from Oct 24, 2019

Conversation

@mysticatea
Copy link
Member

mysticatea commented Oct 20, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #12437.

What changes did you make? (Give an overview)

This PR updates eslint-utils package to fix a bug in ReferenceTracker. The fix is mysticatea/eslint-utils@8f9e481, it was passing through unary/binary/conditional expressions to track.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

Copy link
Member

g-plane left a comment

LGTM, thanks!

Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 49faefb into master Oct 24, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191020.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the issue12437 branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.