Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CLIEngine#addPlugin reset lastConfigArrays (fixes #12425) #12468

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@mysticatea
Copy link
Member

mysticatea commented Oct 20, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #12425

What changes did you make? (Give an overview)

This PR fixes CLIEngine#addPlugin() method to reset lastConfigArrays internal state as well. Because CLIEngine#getRules() gets plugin rules from the lastConfigArrays internal state, this reset is needed.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 23, 2019

@mysticatea Would you like to merge this, or would you prefer that another team member review this?

@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Oct 24, 2019

Thank you for review. I'll merge this.

@mysticatea mysticatea merged commit 0f6d0dc into master Oct 24, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191020.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mysticatea mysticatea deleted the issue12425 branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.