Update: improve report location for no-tabs #12471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
mdjermanovic
added
enhancement
|
I think this can be done as a bug fix or maybe even a chore, instead of enhancement. |
platinumazure
approved these changes
Oct 21, 2019
ilyavolodin
approved these changes
Oct 21, 2019
platinumazure
added
accepted
|
Accepting this as a bug fix. |
|
Merged. Thanks @mdjermanovic for contributing! |
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Apr 1, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request? (put an "X" next to item)
[X] Changes an existing rule
What rule do you want to change?
no-tabs
Does this change cause the rule to produce more or fewer warnings?
same, this PR changes just report locations.
How will the change be implemented? (New option, new default behavior, etc.)?
new default behavior
Please provide some example code that this change will affect:
"\t\ta =\t\t\tb +\tc\t\t;\t\t"What does the rule currently do for this code?
What will the rule do after it's changed?
What changes did you make? (Give an overview)
Report the end location in addition to the start location.
If there are successive tabs, report the end location of the last one.
Is there anything you'd like reviewers to focus on?