Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: improve report location for no-tabs #12471

Merged
merged 1 commit into from Oct 23, 2019
Merged

Update: improve report location for no-tabs #12471

merged 1 commit into from Oct 23, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Oct 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule

What rule do you want to change?

no-tabs

Does this change cause the rule to produce more or fewer warnings?

same, this PR changes just report locations.

How will the change be implemented? (New option, new default behavior, etc.)?

new default behavior

Please provide some example code that this change will affect:

"\t\ta =\t\t\tb +\tc\t\t;\t\t"

What does the rule currently do for this code?

image

What will the rule do after it's changed?

image

What changes did you make? (Give an overview)

Report the end location in addition to the start location.

If there are successive tabs, report the end location of the last one.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 21, 2019
@mdjermanovic mdjermanovic self-assigned this Oct 21, 2019
@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Oct 21, 2019

I think this can be done as a bug fix or maybe even a chore, instead of enhancement. 👍

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 23, 2019

Accepting this as a bug fix.

@platinumazure platinumazure merged commit 89e8aaf into master Oct 23, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191021.6 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure platinumazure deleted the notabs-loc branch Oct 23, 2019
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 23, 2019

Merged. Thanks @mdjermanovic for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.