Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: fix uglified align in key-spacing (fixes #11414) #12472

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@yeonjuan
Copy link
Member

yeonjuan commented Oct 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Count properties on a line as a single line.
I think this PR can fix #11414

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 21, 2019
@yeonjuan yeonjuan changed the title Update: count props on a line as a single in key-spacing (fixes: #11414) Update: fix uglified single line keys align in key-spacing (fixes: #11414) Oct 24, 2019
Copy link
Member

kaicataldo left a comment

Do you mind adding additional tests for all the other configuration options?

@kaicataldo kaicataldo added accepted bug rule and removed triage labels Oct 24, 2019
@yeonjuan yeonjuan changed the title Update: fix uglified single line keys align in key-spacing (fixes: #11414) Update: fix uglified align in key-spacing (fixes: #11414) Oct 25, 2019
@yeonjuan yeonjuan changed the title Update: fix uglified align in key-spacing (fixes: #11414) Update: fix uglified align in key-spacing (fixes #11414) Oct 25, 2019
@yeonjuan
Copy link
Member Author

yeonjuan commented Oct 25, 2019

@kaicataldo I added more test cases for other options. thanks!

Copy link
Member

kaicataldo left a comment

Thanks for working on this! Can we add a few more tests to document the behavior of what should happen when the property node might be multiline (e.g. a multiline object or array value):

({
    foo :1, bar : { qux : 4
    }, baz :3
});
Copy link
Member

aladdin-add left a comment

LGTM, thanks!

beforeColon: false
}],
errors: [
{ messageId: "extraKey", data: { computed: "", key: "foo" }, line: 2, column: 5, type: "Identifier" },

This comment has been minimized.

Copy link
@aladdin-add

aladdin-add Nov 12, 2019

Member

unrelated: it would be better to refactor the messageIds to "extraKey" || "extraComputedKey", rather than passing data: {"computed": ""}

@aladdin-add aladdin-add requested a review from kaicataldo Nov 12, 2019
Copy link
Member

kaicataldo left a comment

LGTM. thanks!

@kaicataldo kaicataldo merged commit 6503cb8 into eslint:master Nov 15, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191102.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@ibc
Copy link

ibc commented Nov 24, 2019

So this change is producing this (IMHO unexpected) behavior:

#12597

kaicataldo added a commit that referenced this pull request Nov 25, 2019
kaicataldo added a commit that referenced this pull request Nov 25, 2019
Revert "Update: Fix uglified object align in key-spacing (fixes #11414) (#12472)"

This reverts commit 6503cb8.
kaicataldo added a commit that referenced this pull request Nov 25, 2019
Revert "Update: Fix uglified object align in key-spacing (fixes #11414) (#12472)"

This reverts commit 6503cb8.
kaicataldo added a commit that referenced this pull request Nov 25, 2019
Revert "Update: Fix uglified object align in key-spacing (fixes #11414) (#12472)"

This reverts commit 6503cb8.
btmills added a commit that referenced this pull request Nov 25, 2019
Revert "Update: Fix uglified object align in key-spacing (fixes #11414) (#12472)"

This reverts commit 6503cb8.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.