Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Provide debug log for parser errors #12474

Merged
merged 1 commit into from Oct 21, 2019
Merged

Conversation

@bradzacher
Copy link
Contributor

@bradzacher bradzacher commented Oct 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

When there's an exception thrown by the parser, currently ESLint swallows this exception.
This is fine for end users, as it allows ESLint to provide a nicer experience, but can make it hard for parser developers to debug problems when reported by users.

This change simply adds a debug log message which includes the exception stack when a parser exception occurs.

That way we can just instruct users to run eslint --debug so we can get the exception stack (amongst other things) from them.

@eslint-deprecated eslint-deprecated bot added the triage label Oct 21, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Looks good to me, thanks for contributing!

@ilyavolodin ilyavolodin added chore core and removed triage labels Oct 21, 2019
@platinumazure platinumazure merged commit 61749c9 into eslint:master Oct 21, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191021.12 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@bradzacher bradzacher deleted the bradzacher:patch-1 branch Oct 21, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants