Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add note about Node.js requiring SSL support (fixes #11413) #12475

Merged
merged 3 commits into from Oct 23, 2019

Conversation

@nzakas
Copy link
Member

@nzakas nzakas commented Oct 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)

I also removed the notice about the npm version as we always support the npm version shipping with the supported Node.js versions.

Is there anything you'd like reviewers to focus on?

Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)
@nzakas nzakas changed the title Docs: Add note about Node.js requiring SSL support Docs: Add note about Node.js requiring SSL support (fixes #11413) Oct 21, 2019
Copy link
Member

@aladdin-add aladdin-add left a comment

@nzakas
Copy link
Member Author

@nzakas nzakas commented Oct 22, 2019

Oh yeah, that’s a good idea

@nzakas nzakas requested a review from aladdin-add Oct 23, 2019
@nzakas
Copy link
Member Author

@nzakas nzakas commented Oct 23, 2019

Updated the getting started guide, too. At some point we should probably just have one location for this information, but this should be good enough for now.

Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks for the update! seems ready to go~~~

@aladdin-add aladdin-add merged commit 8233873 into master Oct 23, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191023.6 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@aladdin-add aladdin-add deleted the issue11413 branch Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants