Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: improve report location for no-trailing-spaces (fixes #12315) #12477

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Oct 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12315

Reports the full location (start+end) of trailing spaces.

Before this fix:

image

After this fix:

image

What changes did you make? (Give an overview)

Added the end to the location.

Is there anything you'd like reviewers to focus on?

It looks a bit unusual to read from the location to calculate the range, but I didn't change that. Tried a version with intermediate variables and it didn't add any clarity (was the opposite, actually).

This is a kind of enhancement, but I think it could be processed as a bug fix (i.e. accepted with 1 confirmation).

@eslint eslint bot added the triage label Oct 22, 2019
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Oct 22, 2019

I'm okay with accepting this as a bugfix.

@platinumazure platinumazure added accepted bug rule and removed triage labels Oct 22, 2019
@platinumazure platinumazure requested a review from btmills Oct 25, 2019
Copy link
Member

btmills left a comment

Nice improvement, LGTM.

@btmills btmills merged commit 4d84210 into master Oct 25, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191022.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the issue12315 branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.