Update: no-trailing-spaces false negatives after comments (fixes #12479) #12480
Conversation
|
Looks good to me, thanks! |
|
LGTM, thanks for the thorough tests around this! |
c6a7745
into
master
16 checks passed
16 checks passed
continuous-integration (Test on Node.js 12 (Windows))
Test on Node.js 12 (Windows) succeeded
Details
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What is the purpose of this pull request? (put an "X" next to item)
[X ] Bug fix #12479
This change produces more errors.
This PR fixes
no-trailing-spacesto report trailing spaces after block comments when theignoreCommentsoption is set totrue.The option allows trailing spaces * in * comments, not after comments.
In addition to the example from #12479, the following are also false negatives (all lines with comments have trailing spaces):
What changes did you make? (Give an overview)
Don't count the last line of a
Blockcomment as a 'comment line' that should be ignored.Is there anything you'd like reviewers to focus on?