Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: no-trailing-spaces false negatives after comments (fixes #12479) #12480

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X ] Bug fix #12479

This change produces more errors.

This PR fixes no-trailing-spaces to report trailing spaces after block comments when the ignoreComments option is set to true.

The option allows trailing spaces * in * comments, not after comments.

In addition to the example from #12479, the following are also false negatives (all lines with comments have trailing spaces):

/* eslint no-trailing-spaces: ["error", { ignoreComments: true }]*/ 

/* */     

/* */foo     

/* 
*/foo     

What changes did you make? (Give an overview)

Don't count the last line of a Block comment as a 'comment line' that should be ignored.

Is there anything you'd like reviewers to focus on?

Copy link
Member

@platinumazure platinumazure left a comment

Looks good to me, thanks!

@platinumazure platinumazure requested a review from btmills Oct 25, 2019
Copy link
Member

@btmills btmills left a comment

LGTM, thanks for the thorough tests around this!

@btmills btmills merged commit c6a7745 into master Oct 25, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191022.6 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the issue12479 branch Oct 25, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants