Fix: operator-assignment removes and duplicates comments #12485
Merged
Conversation
|
LGTM, thanks! |
|
LGTM |
1744fab
into
master
16 checks passed
16 checks passed
continuous-integration (Test on Node.js 12 (Windows))
Test on Node.js 12 (Windows) succeeded
Details
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
This PR fixes
operator-assignmentto prevent autofix if it would remove or duplicate comments.Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo Link 1
Online Demo Link 2
What did you expect to happen?
Not to remove/duplicate comments.
What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
Check for the comments in the ranges there are going to be removed or copied to prevent fixing.
Is there anything you'd like reviewers to focus on?