Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: operator-assignment removes and duplicates comments #12485

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Oct 23, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

This PR fixes operator-assignment to prevent autofix if it would remove or duplicate comments.

Tell us about your environment

  • ESLint Version: 6.5.1
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Online Demo Link 1

/* eslint operator-assignment: ["error", "always"]*/

x = /* comment */ x + y;

x = x // comment 
	+ y;

Online Demo Link 2

/* eslint operator-assignment: ["error", "never"]*/

x /* comment */ += y;

x // comment
	+= y;

What did you expect to happen?

Not to remove/duplicate comments.

What actually happened? Please include the actual, raw output from ESLint.

/* eslint operator-assignment: ["error", "always"]*/

x += y;

x += y;
/* eslint operator-assignment: ["error", "never"]*/

x /* comment */ = x /* comment */ + y;

x // comment
	= x // comment
	+ y;

What changes did you make? (Give an overview)

Check for the comments in the ranges there are going to be removed or copied to prevent fixing.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 23, 2019
Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@platinumazure platinumazure requested a review from btmills Oct 25, 2019
Copy link
Member

btmills left a comment

LGTM

@btmills btmills merged commit 1744fab into master Oct 25, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191023.9 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the operatorassignment-comments branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.