Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add notice about `function` keyword in keyword-spacing #12524

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@g-plane
Copy link
Member

g-plane commented Nov 3, 2019

What is the purpose of this pull request? (put an "X" next to item)

Documentation update

What changes did you make? (Give an overview)

Added notice about function keyword to reduce confusion.

Copy link
Member

kaicataldo left a comment

One small suggestion, but otherwise this LGTM!

docs/rules/keyword-spacing.md Outdated Show resolved Hide resolved
Copy link
Member

platinumazure left a comment

Looks good to me, outside of Kai's requested change. Thanks!

Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
@kaicataldo kaicataldo merged commit 5868550 into master Nov 5, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191104.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the docs-of-keyword-spacing branch Nov 5, 2019
@kaicataldo
Copy link
Member

kaicataldo commented Nov 5, 2019

Thanks for contributing!

@eslint eslint bot locked and limited conversation to collaborators May 5, 2020
@eslint eslint bot added the archived due to age label May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.