Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: invalid token checking in computed-property-spacing (fixes #12198) #12533

Merged
merged 2 commits into from Nov 22, 2019

Conversation

@yeonjuan
Copy link
Member

yeonjuan commented Nov 5, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix it #12198

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Nov 5, 2019
Copy link
Member

kaicataldo left a comment

Thanks for working on this! Can we include some more complex regression tests like the following?

const foo = {
  [ a[b] ]: 1
}

const bar = {
  [ a/**/ [b /**/ ] ]: 1
}
@kaicataldo kaicataldo added accepted bug rule and removed triage labels Nov 6, 2019
@yeonjuan

This comment has been minimized.

Copy link
Member Author

yeonjuan commented Nov 6, 2019

@kaicataldo
I added more complex test cases.:)

Copy link
Member

kaicataldo left a comment

Thank you for contributing! This LGTM.

Copy link
Member

btmills left a comment

Thanks for this @yeonjuan! This is much more robust.

@btmills btmills merged commit 62c7038 into eslint:master Nov 22, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191106.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@yeonjuan yeonjuan deleted the yeonjuan:ccomputed-key branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.