Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add funding field to package.json #12543

Merged
merged 1 commit into from Nov 8, 2019
Merged

Chore: Add funding field to package.json #12543

merged 1 commit into from Nov 8, 2019

Conversation

@nzakas
Copy link
Member

nzakas commented Nov 7, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Add the new funding field to package.json. See:

What changes did you make? (Give an overview)

Added funding field to package.json. Note that this field may be an object or a string. I chose to make it a string because the object has redundant information in it (the type of funding can be inferred from the URL).

Is there anything you'd like reviewers to focus on?

Any syntax errors. :)

@nzakas nzakas added the chore label Nov 7, 2019
@platinumazure
Copy link
Member

platinumazure commented Nov 7, 2019

Question: Should we do the same on other projects in the organization?

@nzakas
Copy link
Member Author

nzakas commented Nov 7, 2019

@platinumazure Excellent point! Yes, we should go through and do that on other projects, too. I think Espree is probably the most important one to add it to.

Copy link
Member

kaicataldo left a comment

LGTM

@nzakas nzakas merged commit 575a98d into master Nov 8, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191107.15 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@nzakas nzakas deleted the fundjson branch Nov 8, 2019
@eslint eslint bot locked and limited conversation to collaborators May 8, 2020
@eslint eslint bot added the archived due to age label May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.