Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ignore marker-only comments in spaced-comment (fixes #12036) #12558

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 12, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #12036

What changes did you make? (Give an overview)

If the whole comment is equal to any of the specified markers, that comment will be ignored by this rule.

This applies to both line comments and block comments.

Is there anything you'd like reviewers to focus on?

This indirectly allows /***/ and //* ("*" is always a marker).

Copy link
Member

platinumazure left a comment

Looks good to me. I have no concerns with the * markers at this point, but let's see what other team members think.

@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Nov 12, 2019

I think this is reasonable.

Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 1110045 into master Nov 15, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191112.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the issue12036 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.