Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add GitHub organization to Sponsor button #12562

Merged
merged 1 commit into from Nov 13, 2019
Merged

Conversation

@btmills
Copy link
Member

btmills commented Nov 13, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

I added the @eslint organization to FUNDING.yml so that the "Sponsor" button on the eslint/eslint repository shows GitHub Sponsors as an option in addition to Open Collective.

Is there anything you'd like reviewers to focus on?

The FUNDING.yml docs haven't been updated to specifically mention sponsoring teams, so I'm hoping the format for teams is the same as for individual users.

@eslint eslint bot added the triage label Nov 13, 2019
@btmills btmills added chore evaluating and removed triage labels Nov 13, 2019
@ilyavolodin
Copy link
Member

ilyavolodin commented Nov 13, 2019

I don't know if we need both. Github org sponsorship goes through OpenCollective (i.e. all the donations through Github will end up in our OpenCollective account).

@btmills
Copy link
Member Author

btmills commented Nov 13, 2019

It seemed weird to me that the Sponsor button on https://github.com/eslint took me to the GitHub Sponsors page, whereas the Sponsor button on https://github.com/eslint/eslint showed a dialog linking to Open Collective. If we're fine with that, then this PR can be closed.

@platinumazure
Copy link
Member

platinumazure commented Nov 13, 2019

@btmills Does this PR resolve the inconsistency you described?

@btmills
Copy link
Member Author

btmills commented Nov 13, 2019

In theory, merging this would then include the GitHub organization in the Sponsors modal on https://github.com/eslint/eslint, but I can’t verify that ahead of time. My plan, if we want to add this at all, would be to merge this, check the modal, and revert this if it didn’t work.

@platinumazure
Copy link
Member

platinumazure commented Nov 13, 2019

I'd love to give users a consistent experience, so I'm 👍 to merging this and testing, but I'll defer to the rest of the team.

@kaicataldo
Copy link
Member

kaicataldo commented Nov 13, 2019

I agree that we should have all the sponsorship links go to the same destination. Could we solve this problem by putting an additional link to Open Collective on our GitHub Sponsors page and point all the Sponsors links in repositories to that?

@ilyavolodin
Copy link
Member

ilyavolodin commented Nov 13, 2019

@btmills Sorry I wasn't clear. I'm 👍 for adding github as an option, but I think we can remove opencollective from that list, as github will wire all of the money into open collective (basically, github is acting just as an interface).

@mysticatea
Copy link
Member

mysticatea commented Nov 13, 2019

but I can’t verify that ahead of time

For a reference, you can see the preview on https://github.com/eslint/eslint/edit/master/.github/FUNDING.yml

image

@ilyavolodin
Copy link
Member

ilyavolodin commented Nov 13, 2019

Nice find @mysticatea . Here's the link to PR change: https://github.com/eslint/eslint/edit/github-sponsors/.github/FUNDING.yml
I'm actually fine withe the way it looks so, approved.

@kaicataldo
Copy link
Member

kaicataldo commented Nov 13, 2019

Looks like we have consensus from the TSC. Going to merge!

@kaicataldo kaicataldo added accepted and removed evaluating labels Nov 13, 2019
@kaicataldo kaicataldo merged commit 07d398d into master Nov 13, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191113.12 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the github-sponsors branch Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.