Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve report location for object-curly-spacing #12563

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 13, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

Change object-curly-spacing report locations.

What changes did you make? (Give an overview)

  • For missing spaces, the difference is small, the rule will now report complete loc of the curly braces instead of just loc.start.
  • For disallowed spaces, the rule will now report the location of spaces (the range that should be removed) instead of the location of curly braces. like this:

image

Is there anything you'd like reviewers to focus on?

Since this doesn't change the start line, it produces neither more nor fewer warnings, even in the case of eslint-disable-* comments.

I guess this could be accepted as a bug fix?

@eslint eslint bot added the triage label Nov 13, 2019
Copy link
Member

ilyavolodin left a comment

LGTM. Yes, this should be a bug fix

@ilyavolodin ilyavolodin added accepted bug rule and removed triage labels Nov 14, 2019
Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit 40c8c32 into master Nov 15, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191113.21 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the objectcurlyspacing-loc branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.