Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Include node version in cache #12582

Merged
merged 3 commits into from Dec 6, 2019

Conversation

@fa93hws
Copy link
Contributor

fa93hws commented Nov 20, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Add node version to the key used in cache.

the result from the linting is possible to be different (some rules may fail) when the node is upgraded or downgraded.

Is there anything you'd like reviewers to focus on?
N/A

@eslint eslint bot added the triage label Nov 20, 2019
@fa93hws fa93hws changed the title include node version in cache New: Include node version in cache Nov 20, 2019
@fa93hws fa93hws force-pushed the fa93hws:include-node-version-in-cache branch from a0ad07a to 640daec Nov 20, 2019
Copy link
Member

kaicataldo left a comment

With the widespread use of tools like nvm, this seems like a good idea to me. Are there any tests we can include to cover this change?

@fa93hws

This comment has been minimized.

Copy link
Contributor Author

fa93hws commented Nov 21, 2019

With the widespread use of tools like nvm, this seems like a good idea to me. Are there any tests we can include to cover this change?

I can add it together with the eslint version.

fa93hws added 2 commits Nov 21, 2019
@fa93hws fa93hws requested a review from kaicataldo Nov 21, 2019
@kaicataldo kaicataldo added tsc agenda and removed bug labels Nov 21, 2019
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Nov 21, 2019

Even though this is a core change, it’s such a small one that I don’t think it should have to go through the RFC process. That being said, I think we should bring this to the TSC.

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Nov 21, 2019

TSC Summary

This PR proposes to include the Node version when hashing the cache key, ensuring that the cache is busted when consecutive linting runs are executed with different Node versions.

TSC Question

Should we accept this?

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Dec 6, 2019

This proposal was accepted at today's TSC meeting.

Copy link
Member

kaicataldo left a comment

LGTM, thank you!

Copy link
Member

platinumazure left a comment

Looks good to me, thanks for contributing!

@kaicataldo kaicataldo merged commit a230f84 into eslint:master Dec 6, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20191121.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@fa93hws fa93hws deleted the fa93hws:include-node-version-in-cache branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.