Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: do not recommend require-atomic-updates (refs #11899) #12599

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Nov 25, 2019

refs #11899 (comment)

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)
The TSC made a determination to remove require-atomic-updates from eslint:recommended, but it looks like we didn't end up making that change.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@kaicataldo kaicataldo force-pushed the fix-require-atomic-updates-recommended branch from 99e4dd8 to 3e4e439 Nov 25, 2019
@kaicataldo kaicataldo changed the title Update: remove require-atomic-updates from eslint:recommended (refs #… Update: do not recommend require-atomic-updates (refs #11899) Nov 25, 2019
@ljharb
ljharb approved these changes Nov 25, 2019
jackodsteel added a commit to jackodsteel/cacophony-api that referenced this pull request Dec 4, 2019
Also turned off a random check that got introduced that's due to be disabled as it's too noisy
(although maybe we consider fixing these if that's possible?)
eslint/eslint#12599
Also bumped the local eslint version as it's behind what gets installed by travis.
@kaicataldo kaicataldo merged commit 6e36d12 into master Dec 4, 2019
18 checks passed
18 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 13.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 8.x)
Details
@github-actions
Test (ubuntu-latest, 8.10.0)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message Commit message follows guidelines
Details
@azure-pipelines
continuous-integration Build #20191125.3 succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the fix-require-atomic-updates-recommended branch Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants