Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add suggestions for no-unsafe-negation (fixes #12591) #12609

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12591

What changes did you make? (Give an overview)

Suggestions for the no-unsafe-negation rule.

Example:

code: "!a in b",
errors: [{
  message: "Unexpected negating the left operand of 'in' operator.",
  suggestions: [
    {
      desc: "Negate 'in' expression instead of its left operand. This changes the current behavior.",
      output: "!(a in b)"
    },
    {
      desc: "Wrap negation in '()' to make the intention explicit. This preserves the current behavior.",
      output: "(!a) in b"
    }
}]

Is there anything you'd like reviewers to focus on?

Messages

Copy link
Member

ilyavolodin left a comment

Very nice change! I think this highlights power of suggestions when applied correctly.

Copy link
Member

kaicataldo left a comment

LGTM. Thanks for contributing!

@btmills btmills merged commit 05f7dd5 into master Dec 20, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191127.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the issue12591 branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.