Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Allow $schema in config #12612

Merged
merged 1 commit into from Dec 19, 2019
Merged

Update: Allow $schema in config #12612

merged 1 commit into from Dec 19, 2019

Conversation

@yordis
Copy link
Contributor

yordis commented Nov 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Allowed the usage of $schema in the configuration. This key is useful for some IDEs to find information about the schema of the JSON 馃し鈥嶁檪

Is there anything you'd like reviewers to focus on?

Make sure that I validated the key correctly

@jsf-clabot
Copy link

jsf-clabot commented Nov 27, 2019

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Nov 27, 2019
@yordis yordis changed the title Whitelist schema Update: Allow $schema in config Nov 29, 2019
@yordis
Copy link
Contributor Author

yordis commented Dec 9, 2019

@kaicataldo could you give me a hand with this, please 馃檹

@kaicataldo
Copy link
Member

kaicataldo commented Dec 10, 2019

I'm not against this change if it helps folks! It looks like there's another PR here, as well as an alternative proposal here.

@kaicataldo
Copy link
Member

kaicataldo commented Dec 10, 2019

Quick note: we generally require core changes to go through the RFC process outlined here, but I personally think this is a small enough change that it might not warrant it. Let's see what the rest of the team thinks.

@g-plane
Copy link
Member

g-plane commented Dec 10, 2019

I also agree that this is a small change.

@ilyavolodin
Copy link
Member

ilyavolodin commented Dec 10, 2019

Agree, this does not require RFC

@ilyavolodin ilyavolodin self-assigned this Dec 11, 2019
@ilyavolodin
Copy link
Member

ilyavolodin commented Dec 11, 2019

I'll champion this. @eslint/eslint-team does anyone want's to support it?

@kaicataldo kaicataldo added accepted and removed evaluating labels Dec 11, 2019
@kaicataldo
Copy link
Member

kaicataldo commented Dec 11, 2019

This has now been accepted.

@kaicataldo kaicataldo merged commit 1600648 into eslint:master Dec 19, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191129.3 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo
Copy link
Member

kaicataldo commented Dec 19, 2019

Thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can鈥檛 perform that action at this time.