Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update no-multi-assign explanation #12615

Merged
merged 2 commits into from Dec 20, 2019
Merged

Docs: Update no-multi-assign explanation #12615

merged 2 commits into from Dec 20, 2019

Conversation

@zypA13510
Copy link
Contributor

@zypA13510 zypA13510 commented Nov 28, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Update no-multi-assign rule documentation:

  • Update description to explain "unexpected results"
    I believe the updated snippet offers a better explanation of why this rule should be used than the previous snippet
  • Update examples to include ES6 syntax
    const and let are already being handled by this rule

Is there anything you'd like reviewers to focus on?
Nothing.

Update description to explain "unexpected results". Also update examples to include ES6 syntax.
Copy link
Member

@kaicataldo kaicataldo left a comment

Thanks for working on this! Just one small comment from me.

docs/rules/no-multi-assign.md Outdated Show resolved Hide resolved
Rephrased by @kaicataldo.
Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

LGTM. This is a nice improvement!

@btmills btmills merged commit d3e43f1 into eslint:master Dec 20, 2019
18 checks passed
18 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 13.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 8.x)
Details
@github-actions
Test (ubuntu-latest, 8.10.0)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message PR title follows commit message guidelines
Details
@azure-pipelines
continuous-integration Build #20191205.1 succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
@azure-pipelines
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
@zypA13510 zypA13510 deleted the zypA13510:patch-1 branch Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants