Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify suggestion's data in Working with Rules (refs #12606) #12617

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 28, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

refs #12606 (first item only)

What changes did you make? (Give an overview)

Added a section in working-with-rules to clarify that suggestion message with placeholders should have its own data.

Is there anything you'd like reviewers to focus on?

Copy link
Member

platinumazure left a comment

Looks good, thanks for contributing!

@platinumazure platinumazure added accepted core and removed triage labels Nov 28, 2019
Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit b41677a into master Nov 29, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191128.5 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@platinumazure platinumazure deleted the suggestions-data-docs branch Nov 29, 2019
@platinumazure
Copy link
Member

platinumazure commented Nov 29, 2019

Thanks for contributing!

@eslint eslint bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.