New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no-restricted-imports schema allows multiple paths/patterns objects #12639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Agreed that this should be a semver-patch bug fix.
btmills
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agreed this can be semver-minor.
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
[X] Other, please explain:
At the moment,
no-restricted-imports
schema allows multiple objects withpaths
/patterns
keys:Online Demo Link
This shouldn't be allowed because it isn't documented and it doesn't work as the user might expect.
paths
andpatterns
are being read only from the first object (at index 0), others are ignored.What changes did you make? (Give an overview)
Fixed the schema to allow only 1 object with this form.
Also added a test to ensure that a configuration without any specified restricted imports is still allowed.
Is there anything you'd like reviewers to focus on?
This isn't related to #12638.
Marked as
fix
rather thanchore
because this change might break a build with an invalid configuration, which anyway didn't work as the user was expecting. Also, looks more like afix
than anupdate
?