Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve report location for array-bracket-spacing #12653

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@mdjermanovic
Copy link
Member

mdjermanovic commented Dec 7, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

Changes array-bracket-spacing report locations.

What changes did you make? (Give an overview)

  • For missing spaces, the difference is small, the rule will now report complete loc of the brackets instead of just loc.start.
  • For disallowed spaces, the rule will now report the location of spaces (the range that should be removed) instead of the location of the brackets. like this:

image

Is there anything you'd like reviewers to focus on?

Since this doesn't change the start line, it produces neither more nor fewer warnings, even in the case of eslint-disable-* comments.

I guess this could be accepted as a bug fix

@eslint eslint bot added the triage label Dec 7, 2019
@kaicataldo kaicataldo added accepted bug rule and removed triage labels Dec 10, 2019
Copy link
Member

kaicataldo left a comment

LGTM! Thanks for contributing!

Copy link
Member

btmills left a comment

LGTM, thanks!

@btmills btmills merged commit 51f9620 into master Dec 20, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191207.2 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the arraybracketspacing-loc branch Dec 20, 2019
@eslint eslint bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.