Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Chore: refactor regex in config comment parser #12662
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain:
A chore to avoid an error that occurs while bundling linter for the online demo.
regjsparser treats escaped
What changes did you make? (Give an overview)
Modified one regex in
Is there anything you'd like reviewers to focus on?
Are the new and the old regexes equivalent.
It's happening with
Would it be possible to lock it at the previous version? It seems to be a deep dependency.
Looks like this chore PR fixed the problem (this build is passing). On the other hand, refactoring a core feat because of the demo build doesn't look nice, although it's a very small change.
platinumazure left a comment
Might as well put this in. The regexes should be equivalent (