Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove bundling of ESLint during release #12676

Merged
merged 1 commit into from Dec 18, 2019
Merged

Conversation

@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Dec 16, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Chore

What changes did you make? (Give an overview)
Now that eslint/website#665 has landed, we can remove the bundling step in our release script. We should keep the bundling step for our Karma browser tests to ensure that the demo works, however.

Is there anything you'd like reviewers to focus on?
Nothing in particular!

@kaicataldo kaicataldo force-pushed the remove-eslint-bundle branch from de9e0d9 to a669117 Dec 16, 2019
@@ -560,7 +560,7 @@ target.mocha = () => {
target.karma = () => {
echo("Running unit tests on browsers");

target.webpack();
target.webpack("production");

This comment has been minimized.

@kaicataldo

kaicataldo Dec 16, 2019
Author Member

Seems like it would be better to test against the production build in our Karma tests.

@kaicataldo kaicataldo merged commit 49c1658 into master Dec 18, 2019
11 of 18 checks passed
11 of 18 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 13.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 8.x)
Details
@github-actions
Test (ubuntu-latest, 8.10.0)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test Browser Test
Details
@azure-pipelines
continuous-integration Build #20191216.4 failed
Details
@azure-pipelines
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) failed
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) failed
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) failed
Details
@azure-pipelines
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) failed
Details
@azure-pipelines
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) failed
Details
@eslint-deprecated
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the remove-eslint-bundle branch Dec 18, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants