Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add object option test cases in yield-star-spacing #12679

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@yeonjuan
Copy link
Member

yeonjuan commented Dec 17, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Added test cases for covering this branch(screenshot) in yield-star-spacing.js.

스크린샷 2019-12-14 오후 7 38 27

This PR increases test coverage for yield-star-spacing

  • Test coverage - yield-star-spacing.js
master PR
Statements 96.55% 100%
Branches 95.45 100%
Functions 100% 100%
Lines 96.55% 100%

What changes did you make? (Give an overview)

Add test cases(object option).

Is there anything you'd like reviewers to focus on?

Copy link
Member

btmills left a comment

Nice, thank you for adding these! LGTM.

@btmills btmills merged commit 9986d9e into eslint:master Dec 20, 2019
11 of 12 checks passed
11 of 12 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@yeonjuan yeonjuan deleted the yeonjuan:add-test-for-yield-spacing branch Jan 3, 2020
@eslint eslint bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.