Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add spacing in comments for no-console rules #12696

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@nikkhn
Copy link
Contributor

nikkhn commented Dec 20, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added spaces before comment markers /* */, not having the spaces was throwing another eslint error :)

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Dec 20, 2019
Copy link
Member

kaicataldo left a comment

LGTM, thank you!

@kaicataldo kaicataldo added documentation and removed triage labels Dec 20, 2019
@kaicataldo kaicataldo merged commit 6b774ef into eslint:master Dec 20, 2019
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo
Copy link
Member

kaicataldo commented Dec 20, 2019

Thanks for contributing to ESLint!

@eslint eslint bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.