Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: description in directive comments (refs eslint/rfcs#33) #12699

Merged
merged 10 commits into from Jan 17, 2020
Merged

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Dec 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Add something to the core: add the support of comments in directive comments.

What changes did you make? (Give an overview)

This PR implements RFC33.

Is there anything you'd like reviewers to focus on?

Are there more proper places for documentation?

@mysticatea mysticatea added enhancement core accepted breaking do not merge labels Dec 22, 2019
@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Dec 22, 2019
@mysticatea mysticatea added this to Implemented, pending review in RFCs Dec 22, 2019
@kaicataldo kaicataldo removed the do not merge label Dec 23, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

I have a few suggestions around the documentation, but I think this is looking great! Thanks for working on this.

docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
tests/lib/linter/linter.js Outdated Show resolved Hide resolved
mysticatea and others added 6 commits Dec 24, 2019
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Copy link
Member

@kaicataldo kaicataldo left a comment

Sorry I missed the typos in my original suggestion. Other than these comments, LGTM!

docs/user-guide/configuring.md Outdated Show resolved Hide resolved
docs/user-guide/configuring.md Outdated Show resolved Hide resolved
@mysticatea
Copy link
Member Author

@mysticatea mysticatea commented Jan 7, 2020

Thank you for your review. I updated this PR.

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM!

Copy link
Member

@btmills btmills left a comment

LGTM. I'm excited to start using this feature!

@btmills btmills merged commit cf46df7 into master Jan 17, 2020
11 checks passed
v7.0.0 automation moved this from Implemented, pending review to Done Jan 17, 2020
@btmills btmills deleted the rfc33 branch Jan 17, 2020
@mysticatea mysticatea moved this from Implemented, pending review to Done in RFCs Jan 23, 2020
montmanu pushed a commit to montmanu/eslint that referenced this issue Mar 4, 2020
…lint#12699)

* Breaking: description in directive comments (refs eslint/rfcs#33)

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* Update tests/lib/linter/linter.js

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* Update docs/user-guide/configuring.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* update configuring.md

Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 17, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age label Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age breaking core enhancement
Projects
No open projects
RFCs
  
Done
v7.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants