Breaking: description in directive comments (refs eslint/rfcs#33) #12699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
enhancement
kaicataldo
reviewed
Dec 24, 2019
I have a few suggestions around the documentation, but I think this is looking great! Thanks for working on this.
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
kaicataldo
reviewed
Jan 6, 2020
Sorry I missed the typos in my original suggestion. Other than these comments, LGTM!
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
|
Thank you for your review. I updated this PR. |
montmanu
pushed a commit
to montmanu/eslint
that referenced
this issue
Mar 4, 2020
…lint#12699) * Breaking: description in directive comments (refs eslint/rfcs#33) * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * Update tests/lib/linter/linter.js Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * Update docs/user-guide/configuring.md Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> * update configuring.md Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request? (put an "X" next to item)
[X] Add something to the core: add the support of comments in directive comments.
What changes did you make? (Give an overview)
This PR implements RFC33.
Is there anything you'd like reviewers to focus on?
Are there more proper places for documentation?