Breaking: no-dupe-class-members checks some computed keys (fixes #12808) #12837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to item)
[X] Changes an existing rule #12808
What changes did you make? (Give an overview)
no-dupe-class-members
was ignoring all computed keys.After this PR, this rule will also check those class members for which
astUtils.getStaticPropertyName
returns a string value. This is new default behavior.The rule will still ignore computed keys with values that are not statically known:
Is there anything you'd like reviewers to focus on?