Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: change default ignore pattern (eslint/rfcs#51) #12888

Merged
merged 1 commit into from Feb 14, 2020
Merged

Breaking: change default ignore pattern (eslint/rfcs#51) #12888

merged 1 commit into from Feb 14, 2020

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Feb 8, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain: change an existing core feature.

What changes did you make? (Give an overview)

This PR implements RFC51 -- changes the default ignore patterns.

  • unignore .eslintrc.js
  • unignore /bower_components/*
  • ignore node_modules/* in subdirectories.

This PR fixes some tests for the unignoring .eslintrc.js.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added core accepted breaking feature labels Feb 8, 2020
@mysticatea mysticatea added this to Implemented, pending review in RFCs Feb 8, 2020
@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Feb 8, 2020
@btmills btmills merged commit cf38d0d into master Feb 14, 2020
11 checks passed
v7.0.0 automation moved this from Implemented, pending review to Done Feb 14, 2020
@btmills btmills deleted the rfc51 branch Feb 14, 2020
@mysticatea mysticatea moved this from Implemented, pending review to Done in RFCs Feb 16, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 14, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age label Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age breaking core feature
Projects
No open projects
RFCs
  
Done
v7.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants