Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Add new rules to eslint:recommended (fixes #12911) #12920

merged 1 commit into from Feb 25, 2020


Copy link

@mdjermanovic mdjermanovic commented Feb 16, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Add something to the core

fixes #12911

This PR adds the following rules to eslint:recommended for v.7.0.0:

  • no-dupe-else-if
  • no-import-assign
  • no-setter-return

What changes did you make? (Give an overview)

Updated the rules and conf/eslint-recommended.js

Also had to remove dead code found by no-dupe-else-if in lib/rules/indent-legacy.js.

Is there anything you'd like reviewers to focus on?

  • I guess no-dupe-if in #12911 is a typo?
  • Are there other files where a change in eslint:recommended should be updated?
  • indent-legacy.

@mdjermanovic mdjermanovic added enhancement core accepted breaking labels Feb 16, 2020
Copy link

@kaicataldo kaicataldo left a comment

LGTM, thank you!

@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Feb 16, 2020
Alhadis added a commit to Alhadis/JG that referenced this issue Feb 24, 2020
nzakas approved these changes Feb 25, 2020
@nzakas nzakas merged commit 78182e4 into master Feb 25, 2020
11 checks passed
v7.0.0 automation moved this from Implemented, pending review to Done Feb 25, 2020
@nzakas nzakas deleted the issue12911 branch Feb 25, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 25, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
accepted archived due to age breaking core enhancement
No open projects

Successfully merging this pull request may close these issues.

3 participants