Fix: false positive new with member in no-extra-parens (fixes #12740) #13375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
# Conflicts: # lib/rules/no-extra-parens.js # tests/lib/rules/no-extra-parens.js
mdjermanovic
requested changes
Jun 20, 2020
lib/rules/no-extra-parens.js
Outdated
Comment on lines
718
to
725
| function isMemberExpInNewCallee(node) { | ||
| if (node.type === "MemberExpression") { | ||
| return node.parent.type === "NewExpression" && node.parent.callee === node | ||
| ? true | ||
| : isMemberExpInNewCallee(node.parent); | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I think this should go up the tree only if it's object child of another MemberExpression, otherwise this would be a false negative:
"new a[(b()).c]"There was a problem hiding this comment.
@mdjermanovic
Thanks! 👍 I added a checking about that and test case.
kaicataldo
approved these changes
Jun 23, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixes #12740
I changed it to allow one parens if there is a "CallExpression" node in "MemberExpression" and when it used as a "NewExpression"'s callee.
Is there anything you'd like reviewers to focus on?