Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Updated puppeteer version to v4.0.0 #13444

Merged
merged 1 commit into from Jul 9, 2020
Merged

Conversation

@odidev
Copy link
Contributor

odidev commented Jun 26, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)

Updated Puppeteer version to latest in package.json as the latest puppeteer version has support for aarch64 platform and also added architecture check to set CHROME_BIN path in karma.conf.js.

@jsf-clabot
Copy link

jsf-clabot commented Jun 26, 2020

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Jun 26, 2020
Added architecture check to set CHROME_BIN path

Signed-off-by: odidev <odidev@puresoftware.com>
@odidev odidev force-pushed the odidev:arm_support branch from 4c3ff48 to 25fd8cb Jun 26, 2020
@kaicataldo kaicataldo added upgrade and removed triage labels Jul 3, 2020
@kaicataldo
Copy link
Member

kaicataldo commented Jul 3, 2020

@eslint/eslint-team Could we get another pair of eyes on this?

@g-plane
Copy link
Member

g-plane commented Jul 3, 2020

We currently have no such testing environment (aarch64), so it's hard to verify.

@nzakas
nzakas approved these changes Jul 7, 2020
Copy link
Member

nzakas left a comment

Looks fine to me. Again, hard to verify but I don't see any issue with merging.

@btmills
btmills approved these changes Jul 9, 2020
Copy link
Member

btmills left a comment

Seems reasonable enough, and nothing in the v3 and v4 changelogs jumps out to me. If something goes wrong I'll put together a manual testing environment on a Raspberry Pi... unless anyone has an Apple Silicon dev kit handy? 😀

@btmills btmills merged commit 748734f into eslint:master Jul 9, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@odidev
Copy link
Contributor Author

odidev commented Jul 10, 2020

Thanks for merging this PR @btmills it will be really helpful if you could make a release with the changes in this PR.

@btmills
Copy link
Member

btmills commented Jul 10, 2020

@odidev you can subscribe to #13470 for updates on our next release, which is currently scheduled for July 17th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.