Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support numeric-separator in no-loss-of-precision (refs #13568) #13574

Merged

Conversation

@anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Aug 16, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added support for numeric separators in no-loss-of-precision

Is there anything you'd like reviewers to focus on?

ref #13568

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 17, 2020

Added "do not merge" as a reminder to update package.json before merging.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Looks good! Just one small jsdoc suggestion

lib/rules/no-loss-of-precision.js Outdated Show resolved Hide resolved
@anikethsaha anikethsaha requested a review from mdjermanovic Aug 20, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic mentioned this pull request Aug 22, 2020
1 of 1 task complete
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 24, 2020

#13609 has been merged, so this can be rebased now, and then we could remove "do not merge" label :)

@anikethsaha anikethsaha force-pushed the anikethsaha:numeric-separate-no-loss-of-precision branch from 44d109e to 648f9b8 Aug 26, 2020
@anikethsaha anikethsaha requested review from mdjermanovic and kaicataldo Aug 26, 2020
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@anikethsaha anikethsaha requested a review from mdjermanovic Aug 26, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

LGTM. Nice work @anikethsaha!

Copy link
Member

@kaicataldo kaicataldo left a comment

Thanks for working on this!

@kaicataldo kaicataldo merged commit 3439fea into eslint:master Aug 29, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.