Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Mark config-related files (refs #13481) #13597

Merged
merged 3 commits into from Aug 21, 2020
Merged

Chore: Mark config-related files (refs #13481) #13597

merged 3 commits into from Aug 21, 2020

Conversation

@nzakas
Copy link
Member

@nzakas nzakas commented Aug 20, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

  1. I've gone through and marked all config-related files with a comment indicating that they should not be changed.
  2. I've added a CODEOWNERS file so I'm notified if any pull request contains changes to any of these files.

It's important that we not make changes to these files as I'm trying to extract this functionality into the eslintrc repo.

Is there anything you'd like reviewers to focus on?

Did I miss any files related to configs?

@nzakas
Copy link
Member Author

@nzakas nzakas commented Aug 20, 2020

Okay, should have fixed all the linting errors. For some reason, running things locally isn't working for me.

@nzakas nzakas merged commit 2bee6d2 into master Aug 21, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@nzakas nzakas deleted the mark-config-files branch Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.