Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: fix id-length false negatives on Object.prototype property names #13670

Merged
merged 1 commit into from Sep 11, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 7, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

This bug fix can produce more linting errors.

Tell us about your environment

  • ESLint Version: v7.8.1
  • Node Version: v12.14.0
  • npm Version: v6.13.4

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015
  }
};

What did you do? Please include the actual source code causing the issue.

Online Demo

/* eslint id-length: ["error", { max: 5 }] */

var toString;

What did you expect to happen?

1 error, because the length of toString is greater than 5.

What actually happened? Please include the actual, raw output from ESLint.

No errors.

What changes did you make? (Give an overview)

Fixed the rule to use Set instead of an object map for the exceptions option. The object map didn't have a null prototype, so all Object.prototype property names were treated as exceptions.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug rule accepted labels Sep 7, 2020
Copy link
Member

@anikethsaha anikethsaha left a comment

LGTM

@mdjermanovic
Copy link
Member Author

@mdjermanovic mdjermanovic commented Sep 11, 2020

I'm going to merge this as a semver-minor bug fix.

It was obviously a bug, the change affects only a few identifiers, and users can specify those identifiers as exceptions if they really want to allow some of them.

@mdjermanovic mdjermanovic merged commit 6f87db7 into master Sep 11, 2020
12 checks passed
@mdjermanovic mdjermanovic deleted the idlength-objectprototype branch Sep 11, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants